fix(grouping): adds aggregationLabel to aggregateColumn call to match public API #7050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Bug Fixes
Contributors@ |
MadChadJack changed the title 
| @MadChadJack would it be possible for you to add some unit tests for this? |
mportuga reviewed Oct 29, 2019
| * @param {Grid} grid grid object | ||
| * @param {GridColumn} column the column we want to aggregate | ||
| * @param {string} aggregationType of the recognised types from uiGridGroupingConstants or one of the custom aggregations from gridOptions | ||
| * @param {string} aggregationLabel to be used instead of the default label. If empty string is passed, label is omitted |
There was a problem hiding this comment.
I couldn't help but notice that you said that "[i]f empty string is passed, label is omitted", Is the point of this to add a way for users to be able to hide the label on the aggregate column by passing an empty string?
There was a problem hiding this comment.
The intention is to be able to pass any label and have each row show that label. For our purposes, we just so happen to want to hide the aggregation labels but for other users this would hopefully allow them to use count and have the label say "Sum" instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I believe this is a bug. The public API has a parameter that can be passed called 'aggregationLabel', but in the public API call, it is not used.
This pull request adds a check to the service to see if that aggregation label is a string and uses that as a label instead, as I believe it was intended.
Public API:
