update(ui-grid): changed sequence of right and left container div elements #7046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Issue Description : NVDA is reading random row no while focus comes to first header cell when grouping grid data. Root Cause: As grouping is part of left container in ui-grid.html, it's div aligned first and then header cell div. Somehow Narrator is also reading no of grouped row along with header cell row. Proposed Fix: Updated right and left container div sequence in ui-grid.html file.
Contributors |
MsDev88 changed the title MsDev88 changed the title 
| This looks like it would cause a different NVDA problem for Western countries. Where we want the left container to be read first. I don't think that I can approve/merge this change. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue Description : NVDA is reading random row no while focus comes to first header cell when grouping grid data.
Root Cause: As expand all controls of grouping is part of left container in ui-grid.html, it's div aligned first and then header cell div. Somehow Narrator is also reading no of grouped row along with header cell row.
Proposed Fix: Updated right and left container div sequence in ui-grid.html file.
Before Changes:
BeforeChanges_NVDA.zip
After Changes:
AfterChange_NVDA.zip
Testing Details:
Unit tests - PASS
Manual testing - PASS
E2E tests - Unable to run locally.