update(ui-grid-header-cell): enable sorting on grid header cell for enter & space-bar keys #7040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…nter & space-bar keys. Issue Description: User is unable to perform sorting actions using keyboard keys on Grid Column Header cell. We have to enable Column Header Menu to perform sorting through Menu option. Proposed Fix: Updated handleKeyDown method to perform sorting on Enter and Spacebar keys in ui-grid-header-cell.js file. Testing Details: Unit tests - PASS Manual testing - PASS E2E testing - PASS
MsDev88 changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue Description: User is unable to perform sorting actions using keyboard keys on Grid Column Header cell. We have to enable Column Header Menu to perform sorting through Menu option.
Proposed Fix: Updated handleKeyDown method to perform sorting on Enter and Spacebar keys in ui-grid-header-cell.js file.
After Changes :
AfterChanges_SortingWithKeyBoard.zip
Testing Details: (Verified Locally)
Unit tests - PASS
Manual testing - PASS
E2E testing - PASS
Note: CI build seems to be broken.