Skip to content

fix(sorting): fixed the priority computing when unsorting using column menu action #6427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2017
Merged

fix(sorting): fixed the priority computing when unsorting using column menu action #6427

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49dce16
fix(sorting): fixed the priority computing when unsorting using colum…
classix-od Oct 19, 2017
f6aeb4b
reafactor(code style): Add spaces to organize it.
mportuga Nov 13, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/js/core/factories/GridColumn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,6 +869,13 @@ angular.module('ui.grid')
* @description Removes column from the grid sorting
*/
GridColumn.prototype.unsort = function () {
//Decrease priority for every col where priority is higher than the removed sort's priority.
var thisPriority = this.sort.priority;
this.grid.columns.forEach(function (col) {
if (col.sort && col.sort.priority !== undefined && col.sort.priority > thisPriority) {
col.sort.priority -= 1;
}
});
this.sort = {};
this.grid.api.core.raise.sortChanged( this.grid, this.grid.getColumnSorting() );
};
Expand Down