Skip to content

Conversation

@Joel-Kornbluh
Copy link

@Joel-Kornbluh Joel-Kornbluh commented Mar 2, 2017

Chrome v56 introduced a new feature called "scroll anchoring" which causes the scroll position to update if element content above the current scroll position has changed.
Since ui-grid-viewport updates the margin of the first line whenever a user is scrolling, scroll anchoring will cause it to get into a scroll loop and scroll indefinitely (i.e. scroll to the end of the grid)

This issue is outlined in detail on the "Scroll Anchoring" feature explainer:

If the DOM changes made by a scroll event handler alter the position of the anchor node, we may encounter feedback loops in which scroll anchoring and the scroll event handler trigger each other ad infinitum.

See issue #6017 for more details.

Chrome v56 introduced a new feature called "scroll anchoring" which causes the scroll position to update if element content above the current scroll position has changed. Since ui-grid-viewport updates the margin of the first line whenever a user is scrolling, scroll anchoring will cause it to get into a scroll loop and scroll indefinitely (i.e. scroll to the end of the grid) See issue angular-ui#6017 for details.
@dlgski
Copy link
Contributor

dlgski commented Mar 3, 2017

According to #6017 this is not an issue in ui-grid 4. This PR would be merged into Ui-Grid 4.0.3 if merged. Is this necessary??

@Joel-Kornbluh
Copy link
Author

Joel-Kornbluh commented Mar 3, 2017

Shouldn't we at least merge it for <=3.2.9?
This issue will soon start affecting all chrome users and it literally makes navigating in the grid impossible.

@dlgski
Copy link
Contributor

dlgski commented Mar 3, 2017

Anything we merge will go into 4.0.3, so the only way anyone can get this change would be by upgrading to 4.0.3 where this is not an issue anyway

@mportuga
Copy link
Member

mportuga commented Mar 6, 2017

@Joel-Kornbluh We are no longer supporting version 3.2.9. Our goal is to keep everyone on the latest version of UI-Grid as much as possible. Our team is too small to maintain older versions of it and guarantee stability.

@mportuga mportuga changed the base branch from master to release-3.x March 27, 2017 15:44
@mportuga mportuga changed the base branch from release-3.x to master March 27, 2017 15:45
@mportuga
Copy link
Member

I reopened this PR into a new branch for release 3.x which will only ever take minor updates like this.

@mportuga mportuga closed this Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants