Force columns with width set by % be integer pixels #5981
   Merged  
   Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.    
 
Browsers affected: Firefox v51 for Windows
This is actually a firefox bug but I think ui-grid should support it. When a div has maxWidth and minWidth that are floats, sometimes the computed width of the div (for reasons I don't yet understand) gets rounded. Most notably, sometimes the width gets rounded up by up to 0.01 pixels so that the computed width is greater than the maxWidth. In a ui-grid, this can cause the divs to sum to larger than the parent row width which causes the last cell to spill to the next row (blurred for confidentiality):

This Firefox bug is evident in the following plunker which was created based on the HTML/CSS output of our ui-grid: https://plnkr.co/edit/d85iZpOtJNmBl1YmRPCp - works fine on Chome and Firefox on Mac, but the computed div widths are slightly greater than maxWidth on Firefox running on Windows. This causes the last cell to spill to the next line. I think the best workaround is to have all pixel values by integers.