Skip to content

Conversation

@kevinralph
Copy link

I added an optional drag and drop effect for the entire column (as opposed to just the header cell) for the movable columns feature. Set 'enableMovableChildCells' to true in gridOptions to use this feature. Screenshot provided below as a preview of the feature.

screen shot 2016-10-26 at 3 17 26 pm

@kevinralph
Copy link
Author

I don't think the failure is related to my changes.

@mportuga
Copy link
Member

mportuga commented Nov 7, 2016

@dlgski This is a change in the design, I am not sure I agree with having the whole column be visible in drag and drop. What do you think? Should we take this change?

@kevinralph What is your reason for wanting this change?

@kevinralph
Copy link
Author

@mportuga It is a design change but it is optional. You have to set enableMovableChildCells to true in gridOptions to see it. A client wanted this in a project I was working on and it would have saved me some time if the grid came with this option. I saw other modules with this included but they lacked in a lot of other areas. I figured I can't be the only person who's faced this problem and if I can save other people time in the future, why not contribute?

@mportuga
Copy link
Member

mportuga commented Nov 7, 2016

Thanks for the reply and contributing @kevinralph! I hadn't noticed the feature toggle, but as long as that is the case, I am okay with it, I will approve and someone else from the UI-grid team should merge it after they review it.

cursor: -moz-grabbing;
cursor: -webkit-grabbing;
font-weight: normal;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a bit of unnecessary extra padding here.

@dlgski
Copy link
Contributor

dlgski commented Nov 8, 2016

I would like to merge this, but it is a new feature and we need documentation on it

@kevinralph
Copy link
Author

@dlgski Ok, great. I'll try to get some documentation in sometime this week.

@dlgski
Copy link
Contributor

dlgski commented Nov 16, 2016

still waiting on documentation

@kevinralph
Copy link
Author

@dlgski Sorry about the wait. I've been busy with work. I'll try to get something in soon.

@mportuga
Copy link
Member

mportuga commented Dec 6, 2016

Closing due to inactivity. Feel free to reopen when you have added the documentation.

@mportuga mportuga closed this Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment