Skip to content

vertical scroll length should never be 0. This will result in division by 0 errors. #5740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2016
Merged

vertical scroll length should never be 0. This will result in division by 0 errors. #5740

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d272fa3
vertical scroll length should never be 0. This will result in divisio…
Oct 13, 2016
fd70a00
Update GridRenderContainer.js
Ladekarl Oct 20, 2016
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update GridRenderContainer.js
  • Loading branch information
@Ladekarl
Ladekarl authored Oct 20, 2016
commit fd70a00ff7ea5253906c062ec544d5976843a3bc
2 changes: 1 addition & 1 deletion src/js/core/factories/GridRenderContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ angular.module('ui.grid')
};

GridRenderContainer.prototype.getHorizontalScrollLength = function getHorizontalScrollLength() {
return this.getCanvasWidth() - this.getViewportWidth() + this.grid.scrollbarWidth;
return this.getCanvasWidth() - this.getViewportWidth() + this.grid.scrollbarWidth !== 0 ? this.getCanvasWidth() - this.getViewportWidth() + this.grid.scrollbarWidth : -1;
};

GridRenderContainer.prototype.getCanvasWidth = function getCanvasWidth() {
Expand Down