[Added] the new feature to ui-grid for multi-select filter #5729

sanjaynishad · 2016-10-09T11:25:55Z

Added the new feature to ui-grid for multi-select filter, it's inspired from the example http://ui-grid.info/docs/#/tutorial/306_custom_filters

already added new repo--> https://github.com/sanjaynishad/ui-grid-multiselect-filter
demo -->http://www.sanjaynishad.com/ui-grid-multiselect-filter/
Thanks..:)

added multi select filter for the data

dlgski · 2016-11-07T18:02:03Z

@sanjaynishad can you please fix this PR so it passes integration? Thank you

sanjaynishad · 2016-11-08T05:59:53Z

Sure, please give me some time. Thanks

sanjaynishad · 2016-11-10T13:30:42Z

@dlgski fixed the PR, Thank You.. :)

dlgski · 2016-11-16T16:17:57Z

src/less/multiselect-filter.less

+}
+
+.ui-grid-multi-select-filter .footer {
+


dlgski · 2016-11-16T16:18:46Z

src/js/core/directives/ui-grid-multiselect-filter.js

@@ -0,0 +1,99 @@
+if (!Element.prototype.matches) {


this should be contained w/in an closure. Also needs 'use strict'

why do you have all this code outside of the module?

dlgski · 2016-11-16T16:23:23Z

src/js/core/directives/ui-grid-multiselect-filter.js

+if (!Element.prototype.matches) {
+ Element.prototype.matches = Element.prototype.msMatchesSelector;
+}
+if (!Element.prototype.closest) {


have you looked at gridUtil ?

I have added these code for IE, btw no need to keep this. removed the same

https://github.com/angular-ui/ui-grid/blob/master/DEVELOPER.md#folder-layout

Create a scope for the compiled directive and $destroy it when removing the element containing the directive.

Move files to feature folder.

franbenz · 2016-11-28T12:50:05Z

Hi @dlgski, any tips on next steps for this PR?

mportuga · 2016-12-14T05:56:06Z

@sanjaynishad and @franbenz Can you please add unit tests to your feature?

mportuga · 2016-12-23T18:40:28Z

If I see no response in 4 days or so, I will be declining this PR for now.

sanjaynishad · 2016-12-23T18:58:21Z

@mportuga I'm not getting time to work on unit test.
can someone please create? otherwise I'll do once I'll free.

mportuga · 2016-12-29T22:40:28Z

I might try if I get some time, but for now, this will just have to stay open.

pradapkumar · 2017-02-09T20:54:35Z

Hi Sanjay
I tried adding your multi-select filter to the grid. when I click "..." button below the column name first time its shows me the pop up and allow me to filter and the grid gets filtered but when I click the same button (...) again second time I getting error and the pop up is not coming up

below is the error

I have added the gridoption

$scope.gridOptions = {
enableSorting: true,
paginationPageSizes: [25, 50, 75],
paginationPageSize: 25,
enablePaginationControls: false,
enableGridMenu: false,
gridMenuShowHideColumns: false,
exporterMenuPdf: false,
enableRowHeaderSelection: false,
enableHorizontalScrollbar: uiGridConstants.scrollbars.NEVER,
enableRowSelection: true,
enableColumnMenus: false,
enableFiltering: true,
columnDefs: $scope.columns,
showGridFooter: true,

};

and header template as below.
field: fieldName, displayName: fieldName, width: currentFieldWidth,
filterHeaderTemplate: '

', enableCellEdit: grdFieldisEditable

Please let me know what mistake I have done.

Thanks

sanjaynishad · 2017-02-20T14:02:53Z

Hi @pradapkumar ,
Sorry, I'm not able to reproduce this issue, it works fine for me. I'll check again one get time.
Thanks.

dlgski · 2017-03-03T19:51:02Z

I cannot merge feature updates without unit tests. Is this PR still necessary?

sanjaynishad · 2017-03-04T06:24:34Z

Will add unit test

mportuga · 2017-06-06T19:11:15Z

@sanjaynishad Any progress on unit tests?

sanjaynishad · 2017-06-06T19:31:33Z

@mportuga I didn't get time.
@dlgski if no one is going to add unit test, you may close this PR

mportuga · 2017-06-14T16:17:52Z

Closing due to lack of tests.

pradapkumar · 2017-06-15T01:46:59Z

@sanjaynishad no prb thanks 😊

sanjaynishad added 2 commits October 4, 2016 22:00

ui-grid-multiselect-filter

b7ab510

added multi select filter for the data

added CSS for the multi-select filter

7904ec7

sanjaynishad added the waiting-response label Nov 7, 2016

updated ui-grid-multiselect-filter.js

18800ed

dlgski suggested changes Nov 16, 2016

View reviewed changes

sanjaynishad and others added 9 commits November 19, 2016 23:05

updated ui-grid-multiselect-filter.js

8bc14e0

updated ui-grid-multiselect-filter.js

4bdf3ff

updated multiselect-filter.less

aa5d06c

Normalize all the line endings

82c7565

feat(multi-select-filter): Feature folder layout

ef67f81

https://github.com/angular-ui/ui-grid/blob/master/DEVELOPER.md#folder-layout

feat(multi-select-filter): Add a tutorial to test the feature.

5855a31

feat(multi-select-filter): fix memory leaks

7f05692

Create a scope for the compiled directive and $destroy it when removing the element containing the directive.

feat(multi-select-filter): fix access to data when appScope is modified

2c961a8

Merge pull request #1 from franbenz/multi-select-filter

d6ee140

Move files to feature folder.

mportuga assigned dlgski Dec 6, 2016

mportuga added needs: Unit Tests and removed waiting-response labels Dec 30, 2016

mportuga added the needs: analysis label Jun 6, 2017

mportuga closed this Jun 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Added] the new feature to ui-grid for multi-select filter #5729

[Added] the new feature to ui-grid for multi-select filter #5729

Uh oh!

sanjaynishad commented Oct 9, 2016

dlgski commented Nov 7, 2016

sanjaynishad commented Nov 8, 2016

sanjaynishad commented Nov 10, 2016

dlgski Nov 16, 2016

sanjaynishad Nov 19, 2016 •

edited

Loading

dlgski Nov 16, 2016

dlgski Nov 16, 2016

sanjaynishad Nov 19, 2016

dlgski Nov 16, 2016

sanjaynishad Nov 19, 2016

franbenz commented Nov 28, 2016

mportuga commented Dec 14, 2016

mportuga commented Dec 23, 2016

sanjaynishad commented Dec 23, 2016

mportuga commented Dec 29, 2016

pradapkumar commented Feb 9, 2017 •

edited

Loading

sanjaynishad commented Feb 20, 2017

dlgski commented Mar 3, 2017

sanjaynishad commented Mar 4, 2017

mportuga commented Jun 6, 2017

sanjaynishad commented Jun 6, 2017

mportuga commented Jun 14, 2017

pradapkumar commented Jun 15, 2017

Labels

5 participants

		}

		.ui-grid-multi-select-filter .footer {

[Added] the new feature to ui-grid for multi-select filter #5729

[Added] the new feature to ui-grid for multi-select filter #5729

Uh oh!

Conversation

sanjaynishad commented Oct 9, 2016

dlgski commented Nov 7, 2016

sanjaynishad commented Nov 8, 2016

sanjaynishad commented Nov 10, 2016

dlgski Nov 16, 2016

Choose a reason for hiding this comment

sanjaynishad Nov 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

dlgski Nov 16, 2016

Choose a reason for hiding this comment

dlgski Nov 16, 2016

Choose a reason for hiding this comment

sanjaynishad Nov 19, 2016

Choose a reason for hiding this comment

dlgski Nov 16, 2016

Choose a reason for hiding this comment

sanjaynishad Nov 19, 2016

Choose a reason for hiding this comment

franbenz commented Nov 28, 2016

mportuga commented Dec 14, 2016

mportuga commented Dec 23, 2016

sanjaynishad commented Dec 23, 2016

mportuga commented Dec 29, 2016

pradapkumar commented Feb 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

sanjaynishad commented Feb 20, 2017

dlgski commented Mar 3, 2017

sanjaynishad commented Mar 4, 2017

mportuga commented Jun 6, 2017

sanjaynishad commented Jun 6, 2017

mportuga commented Jun 14, 2017

pradapkumar commented Jun 15, 2017

Labels

5 participants

sanjaynishad Nov 19, 2016 •

edited

Loading

pradapkumar commented Feb 9, 2017 •

edited

Loading