Skip to content

fix(col-movable): prevent hidden columns triggering unnecessary re-or… #5255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2016
Merged

fix(col-movable): prevent hidden columns triggering unnecessary re-or… #5255

merged 1 commit into from
Jun 22, 2016

Conversation

@dlgski
Copy link
Contributor

@dlgski dlgski commented Mar 24, 2016

This fix checks all the columns between the originalPosition and newPosition. IF they are all hidden, then no re-order event is necessary. If a visible column is found, column re-ordering will be triggered.

Fixes issue: #5254
@JLLeitschuh
Copy link
Contributor

Adding some comments to this would be really helpful.
Explaining why that bit of code is there, what its intentions are and how it works.
@AgDude AgDude merged commit 75b4288 into angular-ui:master Jun 22, 2016
This was referenced Jul 5, 2016
Closed
Merged
@dlgski dlgski deleted the hiddenReorder branch December 6, 2016 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@dlgski @JLLeitschuh @AgDude