Fix intermittent bug where dropdowns are not properly removed after editing. #5145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
swalters added a commit that referenced this pull request Feb 23, 2016
Fix intermittent bug where dropdowns are not properly removed after editing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
One of my users discovered that if you hammer on an editable grid with dropdowns enough, you will occasionally end up with a dropdown left behind that should have been removed from the DOM. This fix makes sure that orphan dropdowns get cleaned up too.
After a quick look at your test suite, I could not come up with a good way to test for this bug, and they're not going to let me spend more time on this. I figured that the fix was still valuable though.