fix(core): add row headers in order #5131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
grid.addRowHeader api now takes a 2nd parameter, order, that is used to insert the row header in proper order. For example, the order is now Grouping/Treeview row header, Expandable row header, then Selection row header if you use those features. Also, expandable RowHeader is now hidden for Group summary rows BREAKING CHANGE: It is possible that your application will show row headers in a different order after this change. If you are adding rowHeaders, use the new order parameter in grid.addRowHeader(colDef, order) to specify where you want the header column.
swalters force-pushed the orderRowHeaders branch from 38f0b14 to 572766d Compare swalters added a commit that referenced this pull request Feb 23, 2016
fix(core): add row headers in order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
grid.addRowHeader api now takes a 2nd parameter, order, that is used to insert the row header in proper order.
For example, the order is now Grouping/Treeview row header, Expandable row header, then Selection row header if you use those features.
Also, expandable RowHeader is now hidden for Group summary rows
BREAKING CHANGE: It is possible that your application will show row headers in a different order after this change.
If you are adding rowHeaders, use the new order parameter in grid.addRowHeader(colDef, order) to specify where you
want the header column.