Skip to content

Conversation

@dsjellz
Copy link

@dsjellz dsjellz commented Feb 11, 2016

No description provided.

@swalters
Copy link
Contributor

How is this different from the colDef.enableSorting option?

@dsjellz
Copy link
Author

dsjellz commented Feb 11, 2016

My understanding was that enableSorting would both hide the column menu items, and disable sorting on the column altogether. I don't actually want to turn sorting off, I just want to disable the column menu item so I can make my own title/icon, and add a couple lines to the action. Since none of the default menu items have id's that I can see, removeMenuItem wasn't an option.

@swalters
Copy link
Contributor

Let me talk this over with the team. We need to keep the public api consistent or we'll have a huge mess on our hands in the future.

@dsjellz
Copy link
Author

dsjellz commented Feb 11, 2016

Sure thing. Happy to make modifications if that what needs to happen. Maybe a better approach would be to simply add id's to the default menu items so that .removeMenuItem could be used on those as well?

@dsjellz dsjellz force-pushed the feature/supressDefaultMenuItems branch 4 times, most recently from 08c3166 to 14cdd85 Compare February 18, 2016 23:30
@dsjellz dsjellz force-pushed the feature/supressDefaultMenuItems branch from 14cdd85 to 2a3c4d0 Compare February 24, 2016 15:22
@mportuga
Copy link
Member

@dlgski Could you instead make the other change that you suggested and add ids to the default menu items? That way we can control this with CSS.

@mportuga
Copy link
Member

Closing due to innactivity

@mportuga mportuga closed this Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants