Fix For Windows 10 Exporter #4640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is a fix for the Windows 10 users. Instead of using `.match` we use `.search` which runs a boolean value. I noticed you guys were trying to get the exact version of IE and that isn’t going to work for Windows 10 users. I instead use the boolean value later to see if we are even in IE. the `navigator.msSaveBlob` is a function in IE 10+ and Edge so knowing that I can call that first and IE9 might possibly not blow up. I haven’t gotten to officially test IE9 yet. If anything, this PR is strictly a proof of concept. Feel free to message me with any questions!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a fix for the Windows 10 users. Instead of using
.matchweuse
.searchwhich runs a boolean value. I noticed you guys weretrying to get the exact version of IE and that isn’t going to work for
Windows 10 users. I instead use the boolean value later to see if we
are even in IE. the
navigator.msSaveBlobis a function in IE 10+ andEdge so knowing that I can call that first and IE9 might possibly not
blow up. I haven’t gotten to officially test IE9 yet. If anything, this
PR is strictly a proof of concept. Feel free to message me with any
questions!