Fix(edit) #4422 Disable end-edit on scroll in deepedit mode to prevent… #4423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… to prevent jump out of edit mode by scroll, which triggered by disable scroller added in 91077e8
swalters added a commit that referenced this pull request Sep 30, 2015
Fix(edit) #4422 Disable end-edit on scroll in deepedit mode to prevent…
frantisekjandos pushed a commit to focscz/ui-grid that referenced this pull request Oct 7, 2015
Fix(edit) angular-ui#4422 Disable end-edit on scroll in deepedit mode to prevent… modified: CHANGELOG.md modified: bower.json modified: misc/tutorial/102_sorting.ngdoc modified: misc/tutorial/103_filtering.ngdoc modified: misc/tutorial/121_grid_menu.ngdoc modified: package.json modified: src/features/edit/js/gridEdit.js modified: src/features/selection/js/selection.js modified: src/js/core/directives/ui-grid.js modified: src/js/core/factories/Grid.js modified: src/js/core/factories/GridColumn.js modified: src/js/core/factories/GridRenderContainer.js modified: src/js/core/services/rowSorter.js modified: src/templates/ui-grid/uiGridHeaderCell.html modified: test/e2e/gridTestUtils.spec.js
frantisekjandos pushed a commit to focscz/ui-grid that referenced this pull request Oct 7, 2015
Fix(edit) angular-ui#4422 Disable end-edit on scroll in deepedit mode to prevent… modified: CHANGELOG.md modified: bower.json modified: misc/tutorial/102_sorting.ngdoc modified: misc/tutorial/103_filtering.ngdoc modified: misc/tutorial/121_grid_menu.ngdoc modified: package.json modified: src/features/edit/js/gridEdit.js modified: src/features/selection/js/selection.js modified: src/js/core/directives/ui-grid.js modified: src/js/core/factories/Grid.js modified: src/js/core/factories/GridColumn.js modified: src/js/core/factories/GridRenderContainer.js modified: src/js/core/services/rowSorter.js modified: src/templates/ui-grid/uiGridHeaderCell.html modified: test/e2e/gridTestUtils.spec.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
… jump out of edit mode by scroll, which triggered by disable scroller added in 91077e8