Skip to content

fix(pagination): avoid initial double firing of paginationChanged #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2015
Merged

fix(pagination): avoid initial double firing of paginationChanged #4186

merged 1 commit into from
Aug 14, 2015

Conversation

@benoror
Copy link
Contributor

@benoror benoror commented Aug 13, 2015

When initially loading a grid with ui.grid.pagination and external pagination enabled, paginationChanged is triggered twice since the watcher values transition from undefined to the initial value

Found while developing a pageSize feature on an alternate pagination project: michaelbromley/angularUtils#212
@benoror
fix(pagination): avoid initial double firing of paginationChanged
1407038 
When initially loading a grid with `ui.grid.pagination` enabled, **paginationChanged** is triggered two times since the watcher values transition from `undefined` to the **initial value** Found while developing a `pageSize` feature on an alternate pagination project: michaelbromley/angularUtils#212
swalters added a commit that referenced this pull request Aug 14, 2015
@swalters
Merge pull request #4186 from benoror/patch-1
24408d8 
fix(pagination): avoid initial double firing of `paginationChanged`
@swalters swalters merged commit 24408d8 into angular-ui:master Aug 14, 2015
@benoror benoror mentioned this pull request Jan 16, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid-pagination Looks Good To Me

3 participants

@benoror @swalters @JLLeitschuh