Add 2 options: In CellNav, add option to highlight the entire row and in Selection add option to show/hide highlight on selection

[mloutraris-ge]

We have had to customize a lot in the grid to achieve the enhancements
requested. We use the grid in a way that makes the row the item which is
actionable, not an individual cell. It would help us a lot if the
following option were added:

1. In the cellNav feature, add an option that will highlight the entire
   row rather than the just the cell on the row that has focus. This will
   act as a highlight bar that will indicate the row that we will act upon.
2. In The selection feature, add an option that does not apply the row
   highlight on selection. This will help us by not causing confusion when
   used in conjunction with the highlight bar. The check box in the header
   will signal the row is selected.

Both changes are included in this pull request.

[mloutraris-ge]

Note: the extra reverts were done by accident, Git hub client was acting up on me.

[AgDude]

Could you please revert all whitespace changes and squash into 1 or 2 commits, so we can easily see what changes are being made.

@PaulL1, it looks like you are helping out with this PR. I would actually like some similar functionality to the "select row" described here. I haven't spent enough time working with cellNav to understand the current limitations, but my thought was to create a flexible API for capturing keyboard and mouse events. I point that out here only so we keep in goal in mind before we get too much options bloat in to the cellNav area.

[mloutraris-ge]

I am desperately trying to…. I am close this pull request because I have to refork and clean up, I am past the point of no return. There changes are small but I agree difficult to see. I am working on that, hope to clear it up and resubmit a cleaner version.

From: Nate Dudenhoeffer [mailto:notifications@github.com]
Sent: Wednesday, June 10, 2015 8:45 AM
To: angular-ui/ng-grid
Cc: Loutraris, Michael (GE Healthcare)
Subject: Re: [ng-grid] Add 2 options: In CellNav, add option to highlight the entire row and in Selection add option to show/hide highlight on selection (#3564)

Could you please revert all whitespace changes and squash into 1 or 2 commits, so we can easily see what changes are being made.

@PaulL1https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PaulL1&d=AwMCaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=kBNKvG9dngqwfqktATW785bWDVwmVXEdzp74XNWQbFU&m=EWENOuabWFWWOnBfsT5vfSlnKpk36jLvQ_8Eac0Wa4E&s=7FYL9s_neTijNeizUrFZsRqeRNAPjiZ-xWpdKsUPWjI&e=, it looks like you are helping out with this PR. I would actually like some similar functionality to the "select row" described here. I haven't spent enough time working with cellNav to understand the current limitations, but my thought was to create a flexible API for capturing keyboard and mouse events. I point that out here only so we keep in goal in mind before we get too much options bloat in to the cellNav area.

—
Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_angular-2Dui_ng-2Dgrid_pull_3564-23issuecomment-2D110735471&d=AwMCaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=kBNKvG9dngqwfqktATW785bWDVwmVXEdzp74XNWQbFU&m=EWENOuabWFWWOnBfsT5vfSlnKpk36jLvQ_8Eac0Wa4E&s=ywFhCU3Kc1pMBwHpj-T-UimAST8eNkDziCrQp9icqd0&e=.

[mloutraris-ge]

Closing this, going to resubmit cleaner version based on current code.

[mloutraris-ge]

Hello,

I have cleaned up the pull request, the new pull request is 3746

#3746

Thanks,
Mike

From: Nate Dudenhoeffer [mailto:notifications@github.com]
Sent: Wednesday, June 10, 2015 8:45 AM
To: angular-ui/ng-grid
Cc: Loutraris, Michael (GE Healthcare)
Subject: Re: [ng-grid] Add 2 options: In CellNav, add option to highlight the entire row and in Selection add option to show/hide highlight on selection (#3564)

Could you please revert all whitespace changes and squash into 1 or 2 commits, so we can easily see what changes are being made.

@PaulL1https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PaulL1&d=AwMCaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=kBNKvG9dngqwfqktATW785bWDVwmVXEdzp74XNWQbFU&m=EWENOuabWFWWOnBfsT5vfSlnKpk36jLvQ_8Eac0Wa4E&s=7FYL9s_neTijNeizUrFZsRqeRNAPjiZ-xWpdKsUPWjI&e=, it looks like you are helping out with this PR. I would actually like some similar functionality to the "select row" described here. I haven't spent enough time working with cellNav to understand the current limitations, but my thought was to create a flexible API for capturing keyboard and mouse events. I point that out here only so we keep in goal in mind before we get too much options bloat in to the cellNav area.

—
Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_angular-2Dui_ng-2Dgrid_pull_3564-23issuecomment-2D110735471&d=AwMCaQ&c=IV_clAzoPDE253xZdHuilRgztyh_RiV3wUrLrDQYWSI&r=kBNKvG9dngqwfqktATW785bWDVwmVXEdzp74XNWQbFU&m=EWENOuabWFWWOnBfsT5vfSlnKpk36jLvQ_8Eac0Wa4E&s=ywFhCU3Kc1pMBwHpj-T-UimAST8eNkDziCrQp9icqd0&e=.