German Translations #356
Closed
German Translations #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Reworked german translations.
| Are we worried at all about causing errors in production code by renaming these? Can we leave both and deprecate 'ge' in the future. |
| #357 brought up the same issue. |
| shall I put the ge.js file back in? |
ghost assigned 
| doing this manually, had to update the name of the file and the key inside the code. 9ec7454 |
| I see that the locale is now 'de' instead of 'ge', that is really great. But did you also merge in the suggested translations as the default german translations are not very accurate? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reworked the german translations and renamed the i18n file for german language to de.js because de is the correct locale for german language.