fix(uiGridHeader): ensure that styles are rebuilt on explicit height #3424
Conversation
Refactor setting of header heights to be more DRY and ensure that rebuildStyles is set when an explicit height is set. Do not set existing explicit heights to null before recalculating height. Fixes: angular-ui#3394, angular-ui#3382, angular-ui#3409
| Note that this has not been validated in this case (as described by @c0bra): "If you have two render containers and one had filters that were on that you then turn off, they other header beds to know to shrink" Is there a tutorial or other example which already has this scenario? |
| This does appears to work with toggling filters. Here is a demo: http://plnkr.co/edit/SmDX8lepvY2ItQOQvH4o?p=info |
| I will try to take a look when I can but I'm out of town till late next week On Fri, May 8, 2015, 3:21 PM Nate Dudenhoeffer notifications@github.com
|
| No problem we were just having some discussion on gitter about this issue. |
AgDude force-pushed the issue-3394 branch 2 times, most recently from 37148bd to 65ad61f Compare 
fix(uiGridHeader): ensure that styles are rebuilt on explicit height
| Looks great, @AgDude. Sorry for taking such a long time to get this merged. |
2 participants
Refactor setting of header heights to be more DRY and ensure that rebuildStyles
is set when an explicit height is set. Do not set existing explicit heights to
null before recalculating height.
Fixes: #3394, #3382, #3409