Fix rowBuilders gridOption attribute #2098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Nice catch. I'd like to add a test that prevents this becoming a regression. |
| @sickan90: any chance of a unit test, then I can merge. |
| Will do that |
sickan90 force-pushed the rowBuilderReturnUndefined branch from 5b9c54b to 03a6093 Compare sickan90 force-pushed the rowBuilderReturnUndefined branch from 03a6093 to ba0c342 Compare | Added a test now. |
c0bra added a commit that referenced this pull request Nov 17, 2014
Fix rowBuilders gridOption attribute
| Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Was using the registerRowBuilder function from grid.js. However, the gridOptions that was returned to my function was "undefined". This commit fixes this issue so that the gridOptions is indeed returned.