Skip to content

Conversation

@PaulL1
Copy link
Contributor

@PaulL1 PaulL1 commented Oct 15, 2014

In particular changes are:

  • all options moved from gridOptions.expandable.xxx to gridOptions.expandableXxxx
  • rowExpandableTemplate changed to expandableRowTemplate
  • defaults added for row height
  • error check added for rowExpandableTemplate, module is disabled with an error
    message if not present
  • overall enableExpandable option provided
In particular changes are: - all options moved from `gridOptions.expandable.xxx` to `gridOptions.expandableXxxx` - `rowExpandableTemplate` changed to `expandableRowTemplate` - defaults added for row height - error check added for `rowExpandableTemplate`, module is disabled with an error message if not present - overall `enableExpandable` option provided
PaulL1 added a commit that referenced this pull request Oct 15, 2014
Breaking(expandable): add ngdoc, standardise option names and format
@PaulL1 PaulL1 merged commit 8dd5dc3 into angular-ui:master Oct 15, 2014
@c0bra c0bra removed the in progress label Oct 15, 2014
@PaulL1
Copy link
Contributor Author

PaulL1 commented Oct 15, 2014

@novice3030 @jpuri : note this pull request, it is breaking change on the expandable module, which will impact you.

@PaulL1 PaulL1 deleted the expandable_doco branch October 15, 2014 23:18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you have added the logError function yet have you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bother. Yes, you're right. The PR is in, but the code isn't actually merged. Hmmm. I guess it'll throw an error until it's there, which is pretty much what it did before I added that extra code.

@jpuri
Copy link
Contributor

jpuri commented Oct 16, 2014

Hey Paul,
Thanks for this good work and taking the left overs from expandable functionality. I was also thinking the expandable functionality needs some work. Some work can also be done to increase its test coverage, I will spend some time on that might be next month.

@PaulL1
Copy link
Contributor Author

PaulL1 commented Oct 16, 2014

Agree that it could use some work. I think the biggest outstanding is that it is really impacting scroll performance. I notice that it uses a lot of ng-if type logic, and I wonder whether that can be replaced by event handlers and $compile/append type logic, as the guys have used in other areas.

I'd like to write some documentation on that, refer #1819, which might be done by then and provide some hints and tips on how this could be done.

@jpuri
Copy link
Contributor

jpuri commented Oct 16, 2014

Hi Paul,
One of the reasons for bad scroll performance is the 2 containers logic, I am not sure what it is but you will see similar performance impact with row selection feature also. In addition the scroll performs bad even when grid all All Collapsed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants