HeaderCellTemplate from column builder used, filter permitted on headerCell #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…erCell Modify defaultColumnBuilder to add a headerCellFilter property to columnDef, allowing a translate to be applied to the header without needing to use a custom header template. Modify ui-grid-header-cell directive to use the header template from the column builder, rather than ignoring it. Minor modifications to templates because the result of a compiled template seems a little different than an inline template, and therefore some classes ended up in different places within the ng-repeat. This could alternatively be fixed in the css, but css is really not my thing. Noted that on my mac in chrome the column menus are not correctly attaching to the columns, but I believe this is a pre-existing problem not caused by this change.
PaulL1 added a commit to PaulL1/ng-grid that referenced this pull request Sep 13, 2014
This branch combines the current upstream/master with pull requests in upstream that made merging angular-ui#1501 in particular difficult. Key changes are: 1. Add hide column to column menu Also includes "google translation" standard translations. Noted that error is occurring intermittently in testing: ui-grid watch for new pinned containers fires watch for right container FAILED Tested and validated that this is also occurring on upstream/master, so presume not to do with changes I've made. 2. Fix column menu with two grids: move from self to scope Moved most of column-menu methods and variables onto $scope so that context didn't get misaligned, and therefore two grids is possible. Added tutorial page showing two grids. 3. HeaderCellTemplate from column builder used, filter permitted on headerCell Modify defaultColumnBuilder to add a headerCellFilter property to columnDef, allowing a translate to be applied to the header without needing to use a custom header template. This translate in my case is angular-translate, used for internationalisation. Modify ui-grid-header-cell directive to use the header template from the column builder, rather than ignoring it, which would address a concern raised by @Shazypro on gitter. Minor modifications to templates because the result of a compiled template seems a little different than an inline template, and therefore some classes ended up in different places within the ng-repeat. This could alternatively be fixed in the css, but css is really not my thing. Noted that on my mac in chrome the column menus are not correctly attaching to the columns, but I believe this is a pre-existing problem not caused by this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Modify defaultColumnBuilder to add a headerCellFilter property to columnDef,
allowing a translate to be applied to the header without needing to use a custom
header template.
Modify ui-grid-header-cell directive to use the header template from the
column builder, rather than ignoring it.
Minor modifications to templates because the result of a compiled template
seems a little different than an inline template, and therefore some classes
ended up in different places within the ng-repeat. This could alternatively
be fixed in the css, but css is really not my thing.
Noted that on my mac in chrome the column menus are not correctly attaching
to the columns, but I believe this is a pre-existing problem not caused by
this change.
The diff on ui-grid-header-cell.js makes it look like far more change than it is. I've pushed the old link content into a compile - post, and written a new pre. I didn't make any changes in the old link, but every line had to be indented so they all show as changed.