Fixed sorting with column menu disabled #1347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Can someone give a hand on a test here? I've tried my best, but can't get it to work and meanwhile this bug is still around. |
| I'll have a look later today. |
| fixed by #1566 (we never did get tests to work. I think we need to invest some time in protractor tests to make it easier) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using the ui-grid option "enableColumnMenu" set to false, the column sorting fails because it tries to hide the columnMenu that doesn't exist. This is fixed by only hiding the columnMenu when enableColumnMenu is set to true.
Plus I found another bad comma in the language files ;)