Skip to content

Fix horizontall scrollbar with aggregate is visible and fix filter "undefined of slice" #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix horizontall scrollbar with aggregate is visible and fix filter "undefined of slice" #1187

wants to merge 2 commits into from

Conversation

@hepr
Copy link

@hepr hepr commented May 14, 2014

No description provided.

@hepr hepr mentioned this pull request May 14, 2014
Closed
@mburbea
Copy link
Contributor

mburbea commented May 27, 2014

25 px is the right answer. The problem is the css for ngAggregate includes a right: -1px causing the row to grow.
Your solution with 26px adds too much past the first group by.
A better fix is to change the css:

.ngAggregate{ right:0px; }

I didn't put my fix in the code like that as I already had custom css rules for my grid to make it look less ugly.
@c0bra
Copy link
Contributor

c0bra commented May 27, 2014

You'll need to alter/re-submit the PR so no changes to the compiled files are included.
@c0bra c0bra self-assigned this May 28, 2014
@c0bra
Copy link
Contributor

c0bra commented Aug 4, 2014

Fixed by #1169
@c0bra c0bra closed this Aug 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@hepr @mburbea @c0bra