Fixing filtering bugs #1157
Merged
Fixing filtering bugs #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…d filtering from working. Example Plunker: plnkr.co/edit/nL1dvjMAnuvHdHPgGv9L
| Thanks for the PR! I will try this locally to see how filtering works with a cellFilter enabled. |
… the columnDefs is pointing to an object
dezsiszabi changed the title 
| @c0bra The second commit of this change caused a regression because an important check was removed from the code. Now if the object contains inner objects it looks for the searched values within the inner object (can even be an infinite loop, I think). Even worse, if the object contains a function it searches for the value within that function code! I think the if statement should be restored. Thanks, |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Example Plunker: plnkr.co/edit/nL1dvjMAnuvHdHPgGv9L
The s array gets created with a split on character ':' .
If the cellFilter is a simple one like 'currency', than s[1] will be undefined and calling slice on it will throw an exception.