Allow custom translate function when slider steps are specified #299
Conversation
Current coverage is |
dist/rzslider.js Outdated
| return this.options.stepsArray[value]; | ||
| }; | ||
| if (this.options.translate) { | ||
| this.customTrFn = function(value, sliderId, label) { |
There was a problem hiding this comment.
Why don't you just do:
this.customTrFn = this.options.translate;?
| Why do you need to use a translate function while using stepsArray? |
| For each point on the slider, the displayed text should be different depending on whether it is the high end or the low end of the slider. |
| Thanks for the updates. Could you add a test to complete the coverage? Also, before I can merge, you need to rebase and squash all your commit into a single one. |
| Done. Thanks for the feedback, and let me know if you'd like to see any other changes. |
| One last thing: can you rebase and squash everything so there is only one commit? |
| Commits squashed! |
| Thanks ;) |
3 participants
Currently, if the user specifies a steps array, their translate function is ignored. This changes that. When a translate function is specified, it will be passed the step value (the array index), the slider ID, and the slider label.