fix: Arguments order fix when parsing array parameters #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

angelov merged 2 commits into angelov:main from daycry:patch-1

May 22, 2024

Contributor

daycry commented May 17, 2024

Fix: Recorder configuration get params

Update Extension.php

6fa116e

Fix: Recorder configuration get params

Contributor Author

daycry commented May 17, 2024

Exception in third-party event subscriber: Library hooks don't exist: ,
#0 C:\laragon\www\mailchimp\vendor\angelov\phpunit-php-vcr\src\Subscribers\ConfigureRecorder.php(43): VCR\Configuration->enableLibraryHooks(Array)
fix: Arguments order fix when parsing array parameters #1 C:\laragon\www\mailchimp\vendor\phpunit\phpunit\src\Event\Dispatcher\DirectDispatcher.php(102): Angelov\PHPUnitPHPVcr\Subscribers\ConfigureRecorder->notify(Object(PHPUnit\Event\TestRunner\ExecutionStarted))
README Info #2 C:\laragon\www\mailchimp\vendor\phpunit\phpunit\src\Event\Dispatcher\DeferringDispatcher.php(45): PHPUnit\Event\DirectDispatcher->dispatch(Object(PHPUnit\Event\TestRunner\ExecutionStarted))
Fixes & refactor #3 C:\laragon\www\mailchimp\vendor\phpunit\phpunit\src\Event\Emitter\DispatchingEmitter.php(246): PHPUnit\Event\DeferringDispatcher->dispatch(Object(PHPUnit\Event\TestRunner\ExecutionStarted))
Allow PHPUnit 12 #4 C:\laragon\www\mailchimp\vendor\phpunit\phpunit\src\TextUI\TestRunner.php(58): PHPUnit\Event\DispatchingEmitter->testRunnerExecutionStarted(Object(PHPUnit\Event\TestSuite\TestSuiteWithName))
Test with multiple PHPUnit versions #5 C:\laragon\www\mailchimp\vendor\phpunit\phpunit\src\TextUI\Application.php(198): PHPUnit\TextUI\TestRunner->run(Object(PHPUnit\TextUI\Configuration\Configuration), Object(PHPUnit\Runner\ResultCache\DefaultResultCache), Object(PHPUnit\Framework\TestSuite))

angelov reviewed

View reviewed changes

src/Extension.php Outdated Show resolved Hide resolved

Update Extension.php

73961a8

daycry commented

View reviewed changes

Contributor Author

daycry left a comment

Done

angelov changed the title ~~Fix: Params recorder configuration~~ fix: Arguments order fix when parsing array parameters

angelov merged commit 07a80f9 into angelov:main

Owner

angelov commented May 22, 2024

Thank you again @daycry. I published a new version with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment