Render effect #20
Render effect #20
Conversation
| | ||
| override fun rotateHue(radian: Float, outputIndex: Int): Bitmap { | ||
| params?.let { | ||
| val colorMatrix = it.matrices[outputIndex] |
There was a problem hiding this comment.
Suggestion: I slightly prefer to create a new ColorMatrix every time this function is invoked, and get rid of the matrices field in Params because it looks cleaner. Although the construction of ColorMatrix takes time, I don't think it is even noticeable. What do you think?
There was a problem hiding this comment.
I have mixed feelings on this one. Creating new is (Thread) safer, but it does add a little overhead. Since, this method is a doggy already, so I'll roll with you on it. :)
| it.hardwareBuffers[outputIndex] = hardwareBuffer | ||
| val bitmap = Bitmap.wrapHardwareBuffer(hardwareBuffer, null) | ||
| ?: throw RuntimeException("Create Bitmap Failed") | ||
| image.close() |
There was a problem hiding this comment.
The hardwareBuffer can be closed at this point because Bitmap.wrapHardwareBuffer already acquires another reference. If the hardwareBuffer is closed here, the hardwareBuffers field in Params can also be removed, I think.
There was a problem hiding this comment.
Excellent suggestion!
2 participants
This ImageProcessor uses the new RenderEffect logic available in Android S. Observations from my Pixel 3a are that the blur is considerably faster than the other processes. Unfortunately, the hue rotation is much slower. This is likely due using a 4x5 matrix vs a 3x3 matrix.