Skip to content

Unify WindowSizeClass usage #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2024
Merged

Unify WindowSizeClass usage #1335

merged 2 commits into from
Apr 12, 2024

Conversation

@jdkoren
Copy link
Contributor

@jdkoren jdkoren commented Apr 10, 2024

No description provided.

@jdkoren jdkoren requested a review from a team as a code owner April 10, 2024 22:48
@jdkoren jdkoren requested a review from bentrengrove April 10, 2024 22:48
arriolac
arriolac reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@arriolac arriolac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also remove the M3 WSC dependency in build.gradle and libs.versions.toml to prevent using the wrong one?

Also please rebase against jetcaster/all_form_factors so that the build passes
@jdkoren jdkoren force-pushed the jdk/window_size_class branch from 2fb6cb1 to 378b9fa Compare April 11, 2024 17:37
@jdkoren jdkoren force-pushed the jdk/window_size_class branch from 378b9fa to ef15624 Compare April 11, 2024 19:24
@jdkoren
Copy link
Contributor Author

jdkoren commented Apr 11, 2024

Can we also remove the M3 WSC dependency in build.gradle and libs.versions.toml to prevent using the wrong one?

Done
@jdkoren jdkoren merged commit 3dbbf09 into jetcaster/all_form_factors Apr 12, 2024
@jdkoren jdkoren deleted the jdk/window_size_class branch April 12, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@jdkoren @arriolac