fix(indexing): avoid fs-extra ESM/CJS interop causing fs.readdir error #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Use native `fs.promises` for directory reads and `fs-extra` for JSON helpers (readJSON/writeJSON/pathExists). - Prevents runtime TypeError when starting with MCP_INDEXING_ENABLED=true by avoiding shape mismatches between ESM/CJS imports. - Verified locally: rebuilt index, processed uploads, and search/context tools work without the previous error. Closes #8
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a runtime TypeError that occurs when starting the server with MCP_INDEXING_ENABLED=true due to ESM/CJS interoperability issues with the fs-extra library. The fix separates concerns by using native fs.promises for directory operations and fs-extra for JSON-specific utilities.
Key Changes
- Replace
fs-extrawildcard import with default import and separatefs.promisesimport - Use
fsp.readdir()for directory reading instead offs.readdir() - Continue using
fs-extrafor JSON operations (readJSON,writeJSON,pathExists)
| 🎉 This PR is included in version 1.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fs.promisesfor directory reads andfs-extrafor JSON helpers (readJSON/writeJSON/pathExists).Closes #8