Fix critical PDF vulnerability (CVE-2024-4139) by replacing pdf-ts with unpdf #6
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR addresses a critical Remote Code Execution vulnerability in the MCP Documentation Server caused by the use of
pdf-ts, which depends on a vulnerable version ofpdfjs-dist(CVE-2024-4139).Vulnerability Details
The server was vulnerable to arbitrary JavaScript execution when processing malicious PDF files through:
The vulnerability existed in the
extractTextFromPdfmethod:This used
pdf-ts@0.0.2which depends on the vulnerablepdfjs-dist@1.10.100, allowing RCE through specially crafted PDFs.Solution
Replaced
pdf-tswithunpdf, a modern, safe PDF text extraction library:Changes Made
pdf-ts@0.0.2and addedunpdf@1.2.1extractTextFromPdfto handle unpdf's return format{ totalPages: number, text: string[] }Security Impact
Testing
All functionality verified:
npm run build✅npm startandnode dist/server.js✅npm run inspect✅Fixes #5.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.