Skip to content

Add customQueryMiddlewareConfig to requests/mutations #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 12, 2023
Merged

Add customQueryMiddlewareConfig to requests/mutations #343

merged 6 commits into from
Dec 12, 2023

Conversation

@kelsonpw
Copy link
Contributor

customQueryMiddlewareConfig is the same as middleware config, but it can be applied per request

Does not have tests, so should be rolled out as RC deployment
@kelsonpw kelsonpw requested review from djih and rctbusk December 12, 2023 00:32
rctbusk
rctbusk requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@rctbusk rctbusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to update the typescript types?
@kelsonpw
Copy link
Contributor Author

Do we also need to update the typescript types?

@rctbusk updated, forgot they are manual updates
@kelsonpw kelsonpw requested a review from rctbusk December 12, 2023 06:46
djih
djih approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@djih djih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the quick changes! 🙏
@kelsonpw kelsonpw merged commit 562599e into master Dec 12, 2023
@kelsonpw kelsonpw deleted the AMP-KW-override branch December 12, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@kelsonpw @djih @rctbusk