Issue 14 create a basicEmpty class of tests that test no deps #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Issue #14 references a situation where an empty dependency array denoted by [] should return no dependencies (as opposed to the normal require/exports/module combination). A define() call that does not contain any dependencies should receive the default require/module/exports combination.
Member
| As I said in the discussion group, I disagree that this should be an optional test. It should be part of the basic tests since it's clearly outlined in the spec. If you want to give implementors some time to fix their implementations before this lands, that's cool. |
Contributor
| I am +1 for merging this and #15, and then send email to amd-implement about the merge and suggest implementers update their configs/implementations to pass the new tests. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue #14 references a situation where an empty dependency array
denoted by [] should return no dependencies (as opposed to the
normal require/exports/module combination). A define() call that
does not contain any dependencies should receive the default
require/module/exports combination.
Compliance passing libs were opted in.
A sample.js file was created to help new impl developers follow a template for adding their own libraries.