Conflict generalisation #242
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #242 +/- ## ============================================ - Coverage 76.83% 76.71% -0.13% - Complexity 2056 2065 +9 ============================================ Files 150 153 +3 Lines 6782 6866 +84 Branches 1184 1188 +4 ============================================ + Hits 5211 5267 +56 - Misses 1177 1202 +25 - Partials 394 397 +3
Continue to review full report at Codecov.
|
if atom not implied by conflict reason
that generalises conflicts
# Conflicts: # src/main/java/at/ac/tuwien/kr/alpha/solver/learning/GroundConflictNoGoodLearner.java
(for upcoming conflict generalisation)
(before, we went to far in some cases and did too many resolutions when computing the 1UIP)
(esp. try in other direction if first direction fails)
because tested classes are also in common package
because tested classes are also in common package
(i.e., does not start with _ or upper-case letter) (this is mainly to notice errors in unit tests!)
... none learned from nogood violated most often
if further resolution is not possible
that made nogoods too small by mapping different variables to the same new variable name
(to learn better nogoods in the case of 3col_crafted)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Related issue: #115