support mcp

[hengyunabc]

No description provided.

[Copilot]

Pull Request Overview

This PR adds MCP (Model Context Protocol) support to Arthas, enabling AI models to interact with Arthas diagnostic tools through a standardized protocol. The implementation includes both streamable and stateless MCP server variants.

• Adds comprehensive MCP server implementation with HTTP/SSE transport
• Integrates 35+ Arthas diagnostic tools as MCP tools (watch, trace, monitor, jad, etc.)
• Updates FastJSON dependency and adjusts monitor command default cycle time

Reviewed Changes

Copilot reviewed 106 out of 106 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pom.xml	Adds arthas-mcp-server module and updates FastJSON to 2.0.58
site/docs/*/monitor.md	Updates monitor command default cycle from 120s to 60s
labs/arthas-mcp-server/src/main/java/com/taobao/arthas/mcp/server/*	Core MCP server implementation with protocol specs, transport layers, and session management
labs/arthas-mcp-server/src/main/java/com/taobao/arthas/mcp/server/tool/*	Tool system with annotations and callback mechanisms
labs/arthas-mcp-server/src/main/java/com/taobao/arthas/mcp/server/tool/function//	Implementation of 35+ Arthas tools as MCP tools

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The shell command escaping logic may be insufficient. Consider using a more robust command escaping mechanism or parameterized command execution to prevent command injection vulnerabilities.

Suggested change

	protected void addParameter(StringBuilder cmd, String flag, String value) {
	if (value != null && !value.trim().isEmpty()) {
	cmd.append(" ").append(flag).append(" ").append(value.trim());
	}
	}
	protected void addParameter(StringBuilder cmd, String value) {
	if (value != null && !value.trim().isEmpty()) {
	// Safely quote the value to prevent command injection
	cmd.append(" '").append(value.trim().replace("'", "'\\''")).append("'");
	}
	}
	protected void addFlag(StringBuilder cmd, String flag, Boolean condition) {
	if (Boolean.TRUE.equals(condition)) {
	cmd.append(" ").append(flag);
	}
	}
	/**
	* 添加引用参数到命令中（用于包含空格的参数）
	*/
	protected void addQuotedParameter(StringBuilder cmd, String value) {
	if (value != null && !value.trim().isEmpty()) {
	cmd.append(" '").append(value.trim()).append("'");
	/**
	* Safely add a parameter to a command argument list.
	*/
	protected void addParameter(java.util.List<String> cmdArgs, String flag, String value) {
	if (value != null && !value.trim().isEmpty()) {
	cmdArgs.add(flag);
	cmdArgs.add(value.trim());
	}
	}
	/**
	* Safely add a single parameter to a command argument list.
	*/
	protected void addParameter(java.util.List<String> cmdArgs, String value) {
	if (value != null && !value.trim().isEmpty()) {
	cmdArgs.add(value.trim());
	}
	}
	protected void addFlag(java.util.List<String> cmdArgs, String flag, Boolean condition) {
	if (Boolean.TRUE.equals(condition)) {
	cmdArgs.add(flag);
	}
	}
	/**
	* 添加引用参数到命令中（用于包含空格的参数）
	* This is now safe, as each argument is a separate element.
	*/
	protected void addQuotedParameter(java.util.List<String> cmdArgs, String value) {
	if (value != null && !value.trim().isEmpty()) {
	cmdArgs.add(value.trim());

[Copilot]

Modifying the collection while iterating over it can cause ConcurrentModificationException. The code removes events from the list during iteration, which is unsafe.

Suggested change

	for (StoredEvent event : events) {
	if (!foundStartEvent) {
	if (event.getEventId().equals(fromEventId)) {
	foundStartEvent = true;
	result.add(event);
	// clear the replayed events
	events.remove(event);
	java.util.Iterator<StoredEvent> iterator = events.iterator();
	while (iterator.hasNext()) {
	StoredEvent event = iterator.next();
	if (!foundStartEvent) {
	if (event.getEventId().equals(fromEventId)) {
	foundStartEvent = true;
	result.add(event);
	// clear the replayed events
	iterator.remove();

[Copilot]

[nitpick] The method throws IllegalArgumentException for null values, but the method signature and documentation don't clearly indicate this behavior. Consider using more specific exception types or documenting the null handling behavior.

Suggested change

	public static Object toTypedObject(Object value, Class<?> type) {
	if (value == null) {
	/**
	* Converts the given value to the specified Java type.
	* <p>
	* @param value the value to convert (must not be null)
	* @param type the target type to convert to (must not be null)
	* @return the converted value
	* @throws IllegalArgumentException if {@code value} or {@code type} is {@code null}
	*/
	public static Object toTypedObject(Object value, Class<?> type) {

[Copilot]

[nitpick] The error detection logic uses multiple hardcoded string patterns and regex matches. Consider consolidating this into a configurable list of error patterns or using a more structured approach for better maintainability.