feat: jfr analyzer #3050

1599-web · 2025-08-10T16:17:23Z

JFR 文件分析功能：前后端实现

本次 PR 实现了对 `.jfr` 文件的分析能力，包括前后端服务的完整集成。

模块说明

后端模块：arthas-jfr-backend
- 使用 Spring Boot 实现 REST 服务
- 支持 .jfr 文件上传、解析、火焰图等数据接口
- 使用 JMC（Java Mission Control）依赖进行 JFR 分析
- 本模块要求使用 JDK 17 编译
前端模块：arthas-jfr-frontend
- 实现用户界面，用于上传 .jfr 文件并展示火焰图
- 技术栈：React

参考项目

该Pr参考了以下优秀的开源项目：

Java Mission Control (JMC) - Oracle 官方的 Java 性能监控工具
VisualVM - 免费的 Java 性能分析工具
FlameGraph - 火焰图生成工具
Jifa - java 应用诊断工具

Pull Request Overview

This PR implements a complete JFR (Java Flight Recorder) file analysis feature with both frontend and backend components. The implementation provides JFR file upload, parsing, and flame graph visualization capabilities using Spring Boot backend and React frontend.

Key changes include:

Complete backend JFR analysis service with Spring Boot
React-based frontend with flame graph visualization
File upload/management system with comprehensive UI
Integration between frontend and backend modules

Reviewed Changes

Copilot reviewed 154 out of 158 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
pom.xml	Adds new frontend and backend modules to main build
labs/arthas-jfr-frontend/	Complete React frontend application with TypeScript, flame graph components, and file management
labs/arthas-jfr-backend/	Spring Boot backend service for JFR file analysis and REST APIs
Frontend components	Flame graph visualization, file upload/table, analysis views, and utility functions
Backend services	JFR analysis service, file management, and REST controllers

Files not reviewed (1)

labs/arthas-jfr-frontend/package-lock.json: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-29T16:09:08Z

labs/arthas-jfr-frontend/package.json

@@ -0,0 +1,28 @@
+{
+ "name": "arthas-fronted",


The package name contains a typo. 'fronted' should be 'frontend' to match the directory name and project purpose.

Suggested change

"name": "arthas-fronted",

"name": "arthas-frontend",

Copilot · 2025-08-29T16:09:08Z

labs/arthas-jfr-frontend/src/utils/formatFlamegraph.ts

+// @ts-nocheck
+// eslint-disable-next-line
+/**
+ * 将JFR后端返回的line格式火焰图数据转换为树结构
+ * @param {Array} data - 形如[[0,1,2], 100]的数组，表示栈帧路径和权重
+ * @param {Object} symbolTable - {0: 'main', 1: 'foo', ...}
+ * @returns {Object} 递归树结构 { name, value, children }
+ */
+export function formatFlamegraph(data, symbolTable) {


Using @ts-nocheck and eslint-disable-next-line at the top of files indicates unresolved type issues or code quality problems. These should be addressed rather than suppressed globally.

Suggested change

// @ts-nocheck

// eslint-disable-next-line

/**

* 将JFR后端返回的line格式火焰图数据转换为树结构

* @param {Array} data - 形如[[0,1,2], 100]的数组，表示栈帧路径和权重

* @param {Object} symbolTable - {0: 'main', 1: 'foo', ...}

* @returns {Object} 递归树结构 { name, value, children }

*/

export function formatFlamegraph(data, symbolTable) {

/**

* 将JFR后端返回的line格式火焰图数据转换为树结构

* @param {Array} data - 形如[[0,1,2], 100]的数组，表示栈帧路径和权重

* @param {Object} symbolTable - {0: 'main', 1: 'foo', ...}

* @returns {Object} 递归树结构 { name, value, children }

*/

// Type definitions

export interface FlamegraphNode {

name: string;

value: number;

children: FlamegraphNode[];

}

export type StackFrame = number[];

export type StackData = [StackFrame, number][];

export type SymbolTable = { [key: number]: string };

export function formatFlamegraph(

data: StackData,

symbolTable: SymbolTable

): FlamegraphNode {

Copilot · 2025-08-29T16:09:09Z

labs/arthas-jfr-frontend/src/utils/format.ts

+ const tb = value;
+ if (tb > 0) result = tb + 'TB ' + result;
+ if (result.length === 0) {
+ if (bytes == 0) return '0B';


Use strict equality (===) instead of loose equality (==) for consistency and to avoid potential type coercion issues.

Suggested change

if (bytes == 0) return '0B';

if (bytes === 0) return '0B';

Copilot · 2025-08-29T16:09:09Z

labs/arthas-jfr-frontend/src/global.less

+ opacity: 0.7;
+}
+
+.dark-mode .flame-empty {


There are extra spaces in the selector '.dark-mode .flame-empty'. This should be '.dark-mode .flame-empty' for consistency with other selectors.

Suggested change

.dark-mode .flame-empty {

.dark-mode .flame-empty {

Copilot · 2025-08-29T16:09:10Z

labs/arthas-jfr-frontend/src/components/FlameGraph/FlameGraph.tsx

+// @ts-nocheck
+// eslint-disable-next-line


This is a critical component with @ts-nocheck disabled. Type safety should be properly implemented for flame graph rendering logic rather than bypassed.

Suggested change

// @ts-nocheck

// eslint-disable-next-line

Copilot · 2025-08-29T16:09:10Z

labs/arthas-jfr-frontend/src/pages/Home/index.tsx

+};
+
+
+export default Home; 


The file imports 'Home' from './Home' but exports it as default, while also defining a 'HomeComponent'. This creates confusion - the export should match the actual component being used.

Suggested change

export default Home;

export default HomeComponent;

Copilot · 2025-08-29T16:09:10Z

labs/arthas-jfr-frontend/src/services/api.ts

+const api = axios.create({
+ baseURL: 'http://localhost:8200',


The baseURL is hardcoded to localhost. This should be configurable through environment variables for different deployment environments.

Suggested change

const api = axios.create({

baseURL: 'http://localhost:8200',

// Use VITE_API_BASE_URL from environment variables, fallback to localhost for development

const api = axios.create({

baseURL: import.meta.env.VITE_API_BASE_URL || 'http://localhost:8200',

Copilot · 2025-08-29T16:09:11Z

labs/arthas-jfr-frontend/src/components/FileUpload/FileUpload.tsx

+// @ts-nocheck
+// eslint-disable-next-line


File upload functionality should have proper TypeScript types enabled for better error catching and code reliability.

Copilot · 2025-08-29T16:09:11Z

labs/arthas-jfr-frontend/src/components/FileTable/FileTable.tsx

+// @ts-nocheck
+// eslint-disable-next-line


The file table component handles important data operations and should have TypeScript checking enabled for type safety.

Copilot · 2025-08-29T16:09:11Z

labs/arthas-jfr-frontend/src/App.tsx

@@ -0,0 +1,27 @@
+// @ts-nocheck


The main App component should have TypeScript checking enabled as it's the root component that defines the application structure.

Suggested change

// @ts-nocheck

...s-jfr-backend/src/main/java/org/example/jfranalyzerbackend/service/impl/FileServiceImpl.java

...ackend/src/main/java/org/example/jfranalyzerbackend/service/impl/JFRAnalysisServiceImpl.java

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

RaymondLam1 · 2025-09-22T01:17:25Z

commit message 要保持统一，一般是 feat/test/fix + 说明

RaymondLam1 · 2025-09-22T01:30:04Z

要写个 README，同时写上参考的其他项目地址

RaymondLam1 · 2025-09-22T01:31:29Z

现在的标题“Feat/jfr analyzer”不规范，改成："feat: jfr analyzer"

RaymondLam1 · 2025-09-26T01:05:53Z

@hengyunabc 我觉得基本可以合并进入 labs

CLAassistant · 2025-10-10T07:36:58Z

All committers have signed the CLA.

hengyunabc requested a review from Copilot August 29, 2025 16:04

Copilot AI reviewed Aug 29, 2025

View reviewed changes

github-advanced-security bot found potential problems Aug 29, 2025

View reviewed changes

...s-jfr-backend/src/main/java/org/example/jfranalyzerbackend/service/impl/FileServiceImpl.java Fixed Show fixed Hide fixed

...ackend/src/main/java/org/example/jfranalyzerbackend/service/impl/JFRAnalysisServiceImpl.java Fixed Show fixed Hide fixed

hengyunabc requested a review from Copilot September 8, 2025 14:50

Copilot AI reviewed Sep 8, 2025

View reviewed changes

1599-web changed the title ~~Feat/jfr analyzer~~ feat: jfr analyzer Sep 22, 2025

1599-web added 8 commits September 22, 2025 15:14

feat: add JFR analysis frontend and backend code

f997816

feat: merge frontend and backend

e46482b

refactor: adjust frontend and backend source code location

b53cc3f

chore: modify jfr analysis backend pom file

25a9353

opt: optimize frontend code flame graph

447b0ea

opt: optimize flame graph display code

e467833

opt: optimize jfr analysis backend code

6f4577b

fix: resolve compilation problems

2f8aa0f

1599-web force-pushed the feat/jfr-analyzer branch from dc757ea to 2f8aa0f Compare September 22, 2025 07:38

1599-web added 2 commits September 22, 2025 18:44

fix: resolve packaging issues and improve README documentation

9f3937d

fix: resolve display issues

96f86a6

Merge branch 'master' into feat/jfr-analyzer

5336ac8

hengyunabc merged commit 0d203b4 into alibaba:master Oct 10, 2025
13 of 14 checks passed

hengyunabc added this to the 4.0.6 milestone Oct 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: jfr analyzer #3050

feat: jfr analyzer #3050

Uh oh!

1599-web commented Aug 10, 2025 •

edited

Loading

Copilot AI left a comment

Copilot AI Aug 29, 2025

Copilot AI Aug 29, 2025

Copilot AI Aug 29, 2025

Copilot AI Aug 29, 2025

Copilot AI Aug 29, 2025

Copilot AI Aug 29, 2025

Copilot AI Aug 29, 2025

Copilot AI Aug 29, 2025

Copilot AI Aug 29, 2025

Copilot AI Aug 29, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

RaymondLam1 commented Sep 22, 2025

RaymondLam1 commented Sep 22, 2025

RaymondLam1 commented Sep 22, 2025

RaymondLam1 commented Sep 26, 2025

CLAassistant commented Oct 10, 2025 •

edited

Loading

Uh oh!

Labels

4 participants

feat: jfr analyzer #3050

feat: jfr analyzer #3050

Uh oh!

Conversation

1599-web commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

JFR 文件分析功能：前后端实现

本次 PR 实现了对 .jfr 文件的分析能力，包括前后端服务的完整集成。

模块说明

参考项目

相关 Issue

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

RaymondLam1 commented Sep 22, 2025

RaymondLam1 commented Sep 22, 2025

RaymondLam1 commented Sep 22, 2025

RaymondLam1 commented Sep 26, 2025

CLAassistant commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Labels

4 participants

1599-web commented Aug 10, 2025 •

edited

Loading

本次 PR 实现了对 `.jfr` 文件的分析能力，包括前后端服务的完整集成。

CLAassistant commented Oct 10, 2025 •

edited

Loading