Upgrade the async profiler library file version #2903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| 这个 pr 同时提交了二进制文件，这个应该由 另外， |
Collaborator
| 另外， 之前因为 async-profiler 官方打包结果里没有支持 musl ，所以我们才自己打包了 musl 的结果： #2481 是不是全部直接引用官方最新的 https://github.com/async-profiler/async-profiler/releases/tag/v3.0 打包结果就可以了？ 如果是的话， |
Contributor Author
| 测试结果：直接引用官方最新的打包结果可以正常运行； |
hengyunabc reviewed Sep 18, 2024
| if (OSUtils.isX86_64() && OSUtils.isMuslLibc()) { | ||
| profilerSoPath = "async-profiler/libasyncProfiler-linux-musl-x64.so"; | ||
| } else if(OSUtils.isX86_64()){ | ||
| if ((OSUtils.isX86_64() && OSUtils.isMuslLibc()) || OSUtils.isX86_64()) { |
Collaborator
There was a problem hiding this comment.
这个代码判断有多余的地方，实际上只判断 OSUtils.isX86_64() 就可以了。 下面 arm 平台的也是。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
根据async profiler pr#733