Skip to content

Conversation

@ntindle
Copy link
Member

@ntindle ntindle commented Aug 11, 2021

Hello, this will require minor configuration in the repo settings.

Please read the full text, and references below before merging.

  1. Merge the PR
  2. You will need to go to Settings -> Pages -> Source -> Branch: Select gh-pages, Folder: Select /(root)
  3. Hit Save
  4. This will deploy a version to algorithm-archivists.github.io/algorithm-archive
  5. If you do not see it here, wait 3-8 minutes.

Up to here, this is non destructive to the current deployment mechanisms.

You can stop here with no side effects to any services. I highly recommend taking a break here and letting github dns propagate

The next change will bring down the site if it is incorrect.

Note: if you are hosting anything else on this domain, do not follow these steps. Comment on the PR and let me know and I will help with the config

  1. Read this doc in full
  2. Follow the steps listed here
  3. Configure the custom domains. My DNS records for tindle.dev look like the following
    image
  4. Add the custom domain to GitHub Pages in Settings -> Pages -> Custom Domain -> Fill out the custom domain with algorithm-archive.org
    My GitHub Pages settings looks like this:

image

@ntindle
Copy link
Member Author

ntindle commented Aug 11, 2021

Response to #790

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stupid question: How does this know to go to algorithm-archivitsts/algorithm-archivists.github.io?

jobs:
build-and-deploy:
runs-on: ubuntu-latest
if: github.repository == 'ntindle/algorithm-archive'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in the final version, this should be algorithm-archivists/algorithm-archive?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, but for now for me to test deployment on my domains it needs to match my branch

npx honkit build

- name: Deploy
uses: JamesIves/github-pages-deploy-action@4.1.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is James Ives?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He built an action that allows automatic deployment to gh-pages branches. You can read the source of the action here; https://github.com/JamesIves/github-pages-deploy-action

@ntindle
Copy link
Member Author

ntindle commented Aug 11, 2021

It knows to go there based on a few things but basically when you enable it in GH Pages it sets it all up for you

Also minor technical note: it would need to be algorithm-archivists.github.io/algorithm-archive unless a custom domain is setup

@ntindle ntindle changed the title WIP: Add support for github action workflows Add support for github action workflows Aug 11, 2021
@ntindle ntindle marked this pull request as ready for review August 11, 2021 14:47
@ntindle ntindle requested a review from leios August 14, 2021 03:17
@leios
Copy link
Member

leios commented Aug 14, 2021

I think this looks good, but I want to play with it a bit. I should have time to do that tomorrow.

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me. Let's give it a shot

@leios leios merged commit dce740f into algorithm-archivists:master Aug 16, 2021
This was referenced Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants