Skip to content

Conversation

@Butt4cak3
Copy link
Contributor

Once merged, this pull request will add JavaScript examples for the arguably two most important algorithm in the archive: Bubble Sort and Bogo Sort.

@Butt4cak3
Copy link
Contributor Author

One thing I want to mention is that the shuffle function that's used in the Bogo Sort implementation does not show up in the book. I left it out to keep the code closer to the other implementations, but I left it in the source file to give people the possibility to use the code more easily.

@leios
Copy link
Member

leios commented Apr 18, 2018

You think we should leave a comment telling them where the shuffle() function is?

@Butt4cak3
Copy link
Contributor Author

Good idea. I'll add one.

@leios
Copy link
Member

leios commented Apr 18, 2018

Or I can add it and merge it now (assuming I can figure out how to do that)

@Butt4cak3
Copy link
Contributor Author

Butt4cak3 commented Apr 18, 2018

Go ahead. I'm on mobile at the moment.
JS uses double forward slash comments. Just don't forget to update the line numbers in the MD file =p

Edit: Or write the comment inside the markdown. I think that would be even better.

@leios
Copy link
Member

leios commented Apr 18, 2018

This was merged in latest commit. Thanks again! (sorry for my messy git)

@leios leios closed this Apr 18, 2018
@Butt4cak3 Butt4cak3 deleted the js-sort branch April 20, 2018 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants