Stable marriage problem implementation in Elvish #794
Conversation
| if (not (empty $proposals)) { | ||
| exit = 0 | ||
| } else { | ||
| continue |
There was a problem hiding this comment.
Okay, that one took me a while to understand, but it makes sense. You should say that if we didn't find any proposal, the algorithm has finished.
There was a problem hiding this comment.
I have changed the condition to be is-empty $proposals (also empty renamed to is-empty) and modified the comment with more explanation of what the algorithm is doing.
| if (==s (kind-of $fem-pref[$female]) string) { | ||
| for elem $proposals { | ||
| men-pref[$elem] = $men-pref[$elem][1..] | ||
| } |
There was a problem hiding this comment.
I don't understand that loop, could you explain it better? No one is married until the end of the algorithm. So... what is that doing?
There was a problem hiding this comment.
When $female has a pair, $fem-pref[$female] is equal to the male's name, i.e., it's no longer a map but a string. So we need to remove $female from all the males who are in $proposals.
Amaras added the Implementation 
| [lang: elvish] |
3 participants
This is an algorithm I came up with so it needs to be checked.