Adding C bubble sort #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
strega-nil reviewed Apr 17, 2018
| @@ -0,0 +1,41 @@ | |||
| #include <stdio.h> | |||
| | |||
| void bubble_sort(int *array, size_t n) { | |||
There was a problem hiding this comment.
I think you should probably include stddef.h here.
strega-nil reviewed Apr 17, 2018
| } | ||
| | ||
| int main() { | ||
| int array[10] = {1, 45, 756, 4569, 56, 3, 8, 5, -10, -4}; |
There was a problem hiding this comment.
Could you use a #define instead of magic constants throughout the code?
There was a problem hiding this comment.
I don't think that's needed really, it's just an example.
| @ubsan I do agree that a |
| @leios I get that but it's a part of the example and not the implementation of bubble sort. |
| yeah, I get that too. I think it's probably fine this way. |
| With this and #80, I think the |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.