Skip to content

Added Rust implementation of Jarvis March #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added Rust implementation of Jarvis March #672

wants to merge 2 commits into from

Conversation

Jess3Jane
Copy link
Contributor

This is a fairly direct port of the Python implementation
@berquist berquist self-requested a review April 24, 2020 14:53
berquist
berquist requested changes May 23, 2020
View reviewed changes
Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! My only request is some comments, such as a docstring for ccw and how the logic inside the loop works.
@berquist berquist added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label May 24, 2020
@berquist
Copy link
Member

@Jess3Jane poke.
@Jess3Jane
Copy link
Contributor Author

Hey, sorry for the long delay, I wasn't checking my github!
@Jess3Jane
Copy link
Contributor Author

Ah, it appears someone came along and implemented it again while I was away, I'll close this then.
@Jess3Jane Jess3Jane closed this Aug 26, 2020
@leios
Copy link
Member

leios commented Aug 26, 2020 •
edited
Loading

Sorry for all the trouble, but thanks for the help!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)

3 participants

@Jess3Jane @berquist @leios