Skip to content

Add Euclidean Algorithm in PowerShell #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 15, 2019
Merged

Add Euclidean Algorithm in PowerShell #626

merged 7 commits into from
Dec 15, 2019

Conversation

PaddyKe
Copy link
Contributor

@PaddyKe PaddyKe commented Oct 1, 2019

No description provided.

c252
c252 requested changes Oct 1, 2019
View reviewed changes
Copy link
Member

@c252 c252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission @PaddyKe .
This was referenced Oct 1, 2019
Closed
Closed
Closed
@Liikt Liikt added Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) labels Oct 2, 2019
@PaddyKe
Copy link
Contributor Author

PaddyKe commented Oct 4, 2019

I added more meaningful Outputs. I think it should be clearer by now what the outputs mean.
@c252
Copy link
Member

c252 commented Oct 20, 2019

Hey, sorry for the late response. I would merge this PR, but I'm on Linux and don't actually have a way to verify if it works. So if one of the other devs could test that, we can merge it.
@leios
Copy link
Member

leios commented Oct 28, 2019 •
edited
Loading

Does anyone have a Windows device to test this with? If not, I might be able to use a VPN?

EDIT: I might be able to use a powershell linux version to test with. I just don't know how to check the quality of the code, itself.
@dovisutu
Copy link
Contributor

dovisutu commented Nov 1, 2019

I have a Windows device (win10) but I can't use it today... Tomorrow I'll try, and if I don't respond, I have to wait until next week.
dovisutu
dovisutu approved these changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@dovisutu dovisutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working. Written Text:

Subtraction-based euclidean algorithm result: 64 Modulus-based euclidean algorithm result: 128
@dovisutu
Copy link
Contributor

dovisutu commented Nov 2, 2019

BTW, Please resolve the conflicts in .editorconfig and book.json.
This PR should be merged after resolving these and approval reviewing by @leios or other members.
@PaddyKe
Copy link
Contributor Author

PaddyKe commented Nov 2, 2019

I've fixed the merge conflicts. Looks like Travis-ci had problems loading the mathjax plugin. When I run "gitbook serve" locally on my PC, it works without errors.
@leios
Copy link
Member

leios commented Dec 15, 2019

This is a known problem. As it seems like everything is resolved, I am happy to merge this.
@leios leios merged commit e1c1d7c into algorithm-archivists:master Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)

5 participants

@PaddyKe @c252 @leios @dovisutu @Liikt