Skip to content

modifying C++ energy calculation to match split-op code. #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 31, 2018
Merged

modifying C++ energy calculation to match split-op code. #533

merged 9 commits into from
Oct 31, 2018

Conversation

leios
Copy link
Member

@leios leios commented Oct 23, 2018

I screwed up with #476 . At first glance, it looked fine, but there were obvious updates necessary. This should match #420.

@rajdakin Sorry for prematurely merging.
@leios leios added Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Oct 23, 2018
zsparal
zsparal suggested changes Oct 23, 2018
View reviewed changes
contents/quantum_systems/code/c++/energy.cpp Outdated
}

void fft(std::vector<std::complex<double>> x, int n, bool inverse) {
std::complex<double> y[n];
Copy link
Contributor

@zsparal zsparal Oct 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunately not standard C++. The way to solve this issue is:

std::vector<std::complex<double>> y(x.size(), std::complex<double>(0.0, 0.0));

This way you don't need either the memset or the push_back loop
berquist
berquist requested changes Oct 27, 2018
View reviewed changes
berquist
berquist requested changes Oct 28, 2018
View reviewed changes
berquist and others added 6 commits October 28, 2018 17:34
@berquist @leios
Update contents/quantum_systems/code/c++/energy.cpp
415305c 
Co-Authored-By: leios <jrs.schloss@gmail.com>
@berquist @leios
Update contents/quantum_systems/quantum_systems.md
5dc4341 
Co-Authored-By: leios <jrs.schloss@gmail.com>
@berquist @leios
Update contents/split-operator_method/split-operator_method.md
785d02a 
Co-Authored-By: leios <jrs.schloss@gmail.com>
@berquist @leios
Update contents/quantum_systems/code/c++/energy.cpp
a460cdb 
Co-Authored-By: leios <jrs.schloss@gmail.com>
@berquist @leios
You are right. Thanks!
be63285 
Co-Authored-By: leios <jrs.schloss@gmail.com>
@leios
fixing unnecessary includes.
2dbda0a
@berquist
Copy link
Member

Ok, looking good.
@berquist berquist merged commit 7460f2a into algorithm-archivists:master Oct 31, 2018
@leios leios deleted the energy_calc_fix_cpp branch December 23, 2018 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest The label for all Hacktoberfest related things! Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)

3 participants

@leios @berquist @zsparal