Stable marriage implementation in Scala #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hey @kenpower, it looks like your Monte Carlo code is still in this PR. Any way you can get rid of those files? |
Gathros added Implementation 
kenpower force-pushed the stable_marrige_scala branch from 57844e1 to 7949624 Compare 
jiegillet requested changes Oct 10, 2018
| | ||
| def main(args: Array[String]): Unit = { | ||
| | ||
| bachelors foreach (b => b.propose()) |
There was a problem hiding this comment.
This is the real matching happens, it shouldn't be in main it should be in StableMarriage somewhere.
kenpower force-pushed the stable_marrige_scala branch from 7949624 to fad401e Compare jiegillet reviewed Oct 10, 2018
| | ||
| def findStableMatches(men: Man*): Unit = { | ||
| bachelors = men.to[ListBuffer] | ||
| bachelors foreach (b => b.propose()) |
There was a problem hiding this comment.
Does this loop adapt dynamically as you add values to bachelors?
There was a problem hiding this comment.
yes... a bit awkward I know. bachelors is acting as a LIFO queue. Maybe better in a while()?
There was a problem hiding this comment.
I forgot about the mutable.queue, I should use that also.
There was a problem hiding this comment.
Yeah, a while loop with a mutable queue would be the most readable solution.
kenpower force-pushed the stable_marrige_scala branch from fad401e to 996e748 Compare jiegillet approved these changes Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.