Skip to content

Conversation

Neverik
Copy link
Contributor

@Neverik Neverik commented Oct 3, 2018

Bubble sort in Smalltalk. Let's revive this language together!
Is this commit okay?

@june128 june128 added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Oct 3, 2018
@june128
Copy link
Member

june128 commented Oct 3, 2018

Hi, thanks for your contribution!
I'm not qualified to review smalltalk really, so someone else has to do the main review.
I have two minor complaints tho.

@june128
Copy link
Member

june128 commented Oct 3, 2018

I think you also didn't provide an example array, that gets sorted.

Copy link
Contributor

@nic-hartley nic-hartley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first two comments are personal opinion, and don't really affect my review one way or the other. Please do add an example showing how it's called, though.

@jiegillet
Copy link
Member

I'm excited to see smalltalk, it's been on my list of languages of interest!

You should also add smalltalk to book.json. See the wiki for more details on how it works!

@Neverik
Copy link
Contributor Author

Neverik commented Oct 4, 2018

Ok, everything should be done now.

Copy link
Contributor

@nic-hartley nic-hartley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, which was the result of going along with my previous CRs.

thisElem := self at: index.
nextElem := self at: index + 1.
(thisElem > nextElem) ifTrue: [
self at: nextIndex put: thisElem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextIndex no longer exists, this should be thisIndex + 1

@Neverik Neverik closed this Oct 5, 2018
@june128 june128 removed Hacktoberfest The label for all Hacktoberfest related things! labels Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)

4 participants