Skip to content

Conversation

jiegillet
Copy link
Member

I did not add FFT code as it is messy in Haskell AFAIK.
Added my name to contributors :p

@leios leios merged commit 78194d0 into algorithm-archivists:master Feb 8, 2018
@leios
Copy link
Member

leios commented Feb 8, 2018

Looks good! Thanks for sending it in! =)

@june128
Copy link
Member

june128 commented Feb 8, 2018

I'm going to add Haskell to the book.json and describe what I changed there (I link the PR then).

@leios
Copy link
Member

leios commented Feb 8, 2018

@julianschacherpp I thought haskell was already in the book.json?

@june128
Copy link
Member

june128 commented Feb 8, 2018

@leios you're right, it is
edit: see below

@leios
Copy link
Member

leios commented Feb 8, 2018

Oh, @julianschacherpp I already made those changes and was going to push them in just a second. I realized the julia tags were also incorrect.

@leios
Copy link
Member

leios commented Feb 8, 2018

I needed to add a small text blurb around the fft-based julia implementation.

@june128
Copy link
Member

june128 commented Feb 8, 2018

@leios ok, perfect :)

@leios
Copy link
Member

leios commented Feb 8, 2018

Done. Thanks @jiegillet and @julianschacherpp !

You guys rock! =)

@june128
Copy link
Member

june128 commented Feb 8, 2018

edit: see below

@jiegillet
Copy link
Member Author

Thanks guys. I tried to mimic what I saw on another page (FFT I think), maybe I got it wrong ^^

@june128
Copy link
Member

june128 commented Feb 8, 2018

@jiegillet the multiple languages with that book.json is quite new and we're missing documentation on that... so it's basically our fault :)

edit: @jiegillet did everything right, the rest of the statement is still true

@leios
Copy link
Member

leios commented Feb 8, 2018

@jiegillet To be fair, the name change from haskell to hs doesn't change too much, it just standardizes everything and ensures that we have syntax highlighting enabled for the language. I had to change my julia tags to jl because I forgot about it too.

The only other change was just to make sure there was some code available in the fft box when people switch to haskell.

What @julianschacherpp said...

@june128
Copy link
Member

june128 commented Feb 8, 2018

ohh, I was a wrong... that you didn't wrote hs instead of haskell is regarding the include-codeblock plug-in and doesn't affect theme-api at all. So you did everything about the theme-api right. That you used haskell instead of hs isn't really important, because this include-codeblock uses this table: http://highlightjs.readthedocs.io/en/latest/css-classes-reference.html#language-names-and-aliases
So it's basically just standardization like @leios said.

I were wrong, sorry.

@june128
Copy link
Member

june128 commented Feb 8, 2018

@jiegillet me confused, see above, in case you didn't see my comment; sry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants