Adding split_op.c and energy.c #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Gathros added the Implementation 
berquist requested changes Aug 5, 2018
There was a problem hiding this comment.
There is a problem with the book:
diff --git a/contents/quantum_systems/quantum_systems.md b/contents/quantum_systems/quantum_systems.md index 300e4ce..dfbaf34 100644 --- a/contents/quantum_systems/quantum_systems.md +++ b/contents/quantum_systems/quantum_systems.md @@ -228,7 +228,7 @@ This ultimately looks like this: {% sample lang="jl" %} [import, lang:"julia"](code/julia/energy.jl) {% sample lang="c" %} -[import:28-, lang:"c_cpp"](code/julia/energy.jl) +[import:28-, lang:"c_cpp"](code/c/energy.c) {% endmethod %} This calculation will be used in many different simulations of quantum systems to check our results.| double xmax; | ||
| int res; | ||
| double dt; | ||
| int timesteps; |
There was a problem hiding this comment.
It makes more physical sense for this to be unsigned.
| | ||
| struct params { | ||
| double xmax; | ||
| int res; |
There was a problem hiding this comment.
It doesn't make physical sense for the resolution to be signed.
| The implementation for split-op seems fine here; however, because we are using the fftw library, would you mind adding in a comment at the top of the file with compilation instructions (or maybe even in the text above the codeblock, but within the C-language method). |
leios previously approved these changes Aug 5, 2018
leios approved these changes Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.