- Notifications
You must be signed in to change notification settings - Fork 28
feat(specs): add sortBy query param and sortingStrategy #5686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
| Can you wait for this PR #5683 to be merged make sure it works ? |
e9d8728 to 6f7519d Compare 6f7519d to 8135795 Compare
ClaraMuller left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark about the documentation.
Let's keep it minimal at this point.
Feel free to put a better phrasing is there is one
Fluf22 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ClaraMuller everything all good on your side?
| @Fluf22 Yes I approved the PR 👍 |
…rated) [skip ci] Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-608
Changes included:
Stacked PRs
🧪 Test
Added test for: