Skip to content

Conversation

@ben-kalmus
Copy link
Contributor

@ben-kalmus ben-kalmus commented Nov 27, 2025

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-608

Changes included:

  • Added new runtime query parameter to compositions run endpoint: "sortBy"
  • Added new setting to Composition schema "sortingStrategy" which allows defining new sorting indices.

Stacked PRs

🧪 Test

Added test for:

  • Upsert composition with sorting strategy
  • Run a composition with a sortBy runtime query param
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 27, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 70627465d9b9ca459de0d32900252f3329f70398
🍃 Generated commit ace82e5588c562e2b652eb6495bffd803acc532a
🌲 Generated branch generated/benk/sortby
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2453
go 2087
php 1972
csharp 1386
python 1302
java 1210
ruby 921
swift 774
scala 23
@ben-kalmus ben-kalmus changed the title feat: add sortBy query param and sortingStrategy feat(clients): add sortBy query param and sortingStrategy Nov 27, 2025
@ben-kalmus ben-kalmus changed the title feat(clients): add sortBy query param and sortingStrategy feat(specs): add sortBy query param and sortingStrategy Nov 27, 2025
@ben-kalmus ben-kalmus marked this pull request as ready for review November 27, 2025 15:19
@ben-kalmus ben-kalmus requested a review from a team as a code owner November 27, 2025 15:19
@ben-kalmus ben-kalmus requested review from Fluf22 and millotp November 27, 2025 15:19
@ClaraMuller
Copy link
Contributor

Can you wait for this PR #5683 to be merged make sure it works ?

Copy link
Contributor

@ClaraMuller ClaraMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark about the documentation.
Let's keep it minimal at this point.
Feel free to put a better phrasing is there is one

@ClaraMuller ClaraMuller requested a review from a team November 28, 2025 10:55
ClaraMuller
ClaraMuller previously approved these changes Nov 28, 2025
Fluf22
Fluf22 previously approved these changes Dec 1, 2025
Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ClaraMuller everything all good on your side?

@ClaraMuller
Copy link
Contributor

@Fluf22 Yes I approved the PR 👍

@Fluf22 Fluf22 dismissed stale reviews from ClaraMuller and themself via c501153 December 2, 2025 16:19
@Fluf22 Fluf22 merged commit fe6e82c into main Dec 2, 2025
33 checks passed
@Fluf22 Fluf22 deleted the benk/sortby branch December 2, 2025 16:57
algolia-bot added a commit that referenced this pull request Dec 2, 2025
…rated) [skip ci] Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Dec 2, 2025
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Dec 2, 2025
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Dec 2, 2025
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Dec 2, 2025
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Dec 2, 2025
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Dec 2, 2025
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Dec 2, 2025
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Dec 2, 2025
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Dec 2, 2025
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Dec 2, 2025
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Dec 2, 2025
algolia/api-clients-automation#5686 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants