Skip to content

chore: fix JavaScript algoliasearch artifacts #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2022
Merged

chore: fix JavaScript algoliasearch artifacts #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/actions/restore-artifacts/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,27 +53,27 @@ runs:
path: clients/algoliasearch-client-javascript/packages/requester-node-http/

# JavaScript
- name: Download client-javascript-algoliasearch artifact
- name: Download clients-javascript artifact
Copy link
Member Author

@shortcuts shortcuts May 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've swapped the order here, as we don't want the js global artifact to override the algoliasearch one, as it happens after
if: ${{ inputs.javascript == 'true' && inputs.type == 'all' }}
uses: actions/download-artifact@v3
with:
name: client-javascript-algoliasearch
name: clients-javascript

- name: Unzip client-javascript-algoliasearch artifact
- name: Unzip clients-javascript artifact
if: ${{ inputs.javascript == 'true' && inputs.type == 'all' }}
shell: bash
run: unzip -q -o client-javascript-algoliasearch.zip && rm client-javascript-algoliasearch.zip
run: unzip -q -o clients-javascript.zip && rm clients-javascript.zip

- name: Download clients-javascript artifact
- name: Download client-javascript-algoliasearch artifact
if: ${{ inputs.javascript == 'true' && inputs.type == 'all' }}
uses: actions/download-artifact@v3
with:
name: clients-javascript
name: client-javascript-algoliasearch

- name: Unzip clients-javascript artifact
- name: Unzip client-javascript-algoliasearch artifact
if: ${{ inputs.javascript == 'true' && inputs.type == 'all' }}
shell: bash
run: unzip -q -o clients-javascript.zip && rm clients-javascript.zip
run: unzip -q -o client-javascript-algoliasearch.zip && rm client-javascript-algoliasearch.zip

# PHP
- name: Download clients-php artifact
Expand Down
15 changes: 6 additions & 9 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,26 +264,23 @@ jobs:
)}}
path: clients/algoliasearch-client-javascript/packages/algoliasearch/

- name: Restore clients
- name: Download JavaScript clients artifact
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
uses: actions/download-artifact@v3
with:
name: clients-javascript
path: clients/algoliasearch-client-javascript/

- name: Unzip JavaScript clients artifact
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
shell: bash
run: unzip -q -o clients-javascript.zip && rm clients-javascript.zip

- name: Setup
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
uses: ./.github/actions/setup
with:
type: minimal

- name: Download JavaScript clients
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
uses: ./.github/actions/restore-artifacts
with:
javascript: true
type: all

- name: Build 'algoliasearch' client
if: ${{ steps.cache.outputs.cache-hit != 'true' }}
run: yarn cli build clients javascript algoliasearch
Expand Down